Repository navigation
feat: build native offline gameplay and simulator qualification - #57
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex review |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bc040c05b0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review Current head 1d4f948 replaces the one-sided score-centering shortcut with a local pinned-Maestro viewport/row containment loop, bounded transport and semantic taps without retries. Recorded-score and persisted completion checks remain required. Please review this head, including protocol cleanup and fail-closed geometry. Local qualification and 40 tooling tests pass; native matrix qualification is pending. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1d4f948624
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
1d4f948 to
930a70d
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
930a70d to
8fbf386
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
9373563 to
86011d8
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Merged at 0e3f2fe. Postmerge dependency security and unpublished site checks passed, but application quality failed two tablet groups. Retained exact original artifacts11140239686 and11140204950: all103declared files match inventory hashes/sizes. Tablet8 reported Device became unreachable during isScreenStatic; tablet10 timed out after saving a completed315-point solo game. One fresh failed-group rerun started October1 at00:44EDT. No existing state-changing tap was replayed; no delivery-success notification has been sent. The original current-head native qualification and public media remain intact. |
|
Postmerge delivery is now verified. Application quality run 36813755877 attempt 2 passed after the one fresh tablet-group retry; dependency security 36813755923 and unpublished-site 36813756047 passed. Exact artifact IDs distinguish both original failed tablets from their passing retries. All 1,011 winning declared artifact files matched downloaded sizes/SHA-256, all ten cold resumes preserved the stored document bytes, eight games completed, and both explicit corruption resets produced empty saves. Original device-unreachable/driver-timeout evidence remains retained. This is unsigned simulator delivery only, not signed-device, VoiceOver, airplane-mode, backup/traffic, TestFlight or store acceptance. One completion notification was sent after verification. |
Summary
Add an offline native iPhone/iPad interface around the shared rules, with acknowledged saves, resume, local history, recovery, native navigation and development assets. Online web/Electron adapters keep their backend authority.
This is partial repository implementation for #40, #41, #42, #44, #45, #46 and #48. Their full release-acceptance work remains open.
Acceptance Criteria
Definition of Done
Validation
Current head
86011d88d87b264e7b3b09011527842321de1c2b, rebased on mainba8d370. Native qualification passed, including all eight solo/three-AI games, both largest-text scenarios, damaged JSON/database preservation and explicit reset/relaunch. Current-head connected Codex review has no findings. All 11 embedded screenshots decode at their original dimensions. The inline original recording loads, seeks and displays native gameplay. All 12 public attachments match original size and SHA256. Final source/check/thread/protection gates are verified before the guarded merge.Phone six needed one fresh failed-group run after its first cold Resume Game tap had no navigation effect. The original saved document remained byte-identical. The failing attempt is retained; no state-changing tap was replayed, source changed or check weakened. The passing retry is identified by artifact ID11135623534 and runAttempt2, because GitHub exposes duplicate same-name artifacts across attempts. All 1,147 retained files, including that failure, match their declared sizes and hashes.
A fresh read-only independent finish review opened 15 real current-source native captures and found no material UI fixes for this unsigned foundation. Independent documentation review returned OK with notes. It confirmed the native storage, simulator, privacy, assets and Help records, and identified older product/design/platform-boundary wording for a separate documentation follow-up. Neither review is owner, signing, hardware or publication approval.
bun run typecheck,bun run lint,bun run test,bun run build:mobile,bun run quality:measure,bun run security: passed locally. 219 unit tests, 1,533 assertions; 10 client journeys; 73 production files/452 functions; highest CRAP 20.0000; zero gate failures.node --test scripts/ios-release/*.test.mjs scripts/ios-assets/*.test.mjs scripts/ios-native/*.test.mjs site/*.test.mjs: 80 tooling/site tests passed. Eight new session/scenario tests require one owned connection, preserve cold relaunch and exact bytes, stop on missing hold/completion effects, and reject unbound flows.actionlint .github/workflows/quality.ymlandgit diff --check: passed.53bbfd3, then timed out during the first simulator boot. No native UI tests ran. Its retained artifact supplied the reviewed CocoaPods lock.beff6ec, passed deployment-mode installation and native setup, hold/reroll and restart/resume on iPhone 17. The SQLite document was byte-identical across relaunch. First boot took about 7½ minutes. Completion failed after two taps did not record scores; the next flow waits for enabled, centered controls and acknowledged scoring. Screenshots also exposed content hidden behind the large navigation header, so the correction uses compact system headers and complete safe-area edges.9373563builds once, then runs four required device groups. Every group verifies the exact source, workflow run, architecture, app identity and artifact hashes before installation. All ten scenarios remain covered. This replaces the serial matrix whose measured startup/driver costs would exceed a one-hour job.bc040c0build passed deployment-mode installation and native privacy inspection. Eleven manifests are present, with the SDK's four missing reasons restored. The iPad 8-dice start/resume scenario also passed. Its groups then exposed driver startup, keyboard-dismissal and scoring-tap failures. All four groups failed; none is treated as full qualification.027459f, completed native iPad games with eight dice solo and ten dice solo/three AI. Ten-dice largest-text start/resume also passed. Both phones still failed their first scoring acknowledgment: traces and screenshots show the target clipped behind the fixed roll footer. Tablet eight-dice AI could not find the first row after resume. The following revision waited for gameplay, centered score targets, retained acknowledgment checks and captured the initial scoring screen.E_SQLITE_DELETE_DATABASEfor missing files and other failures, not the assumed missing-only code. Real-file reset tests now call the deletion adapter instead of force-removing absent files; six regressions failed before repair. Reset enumerates the directory, removes only owned files and verifies absence. Inspection, permission and still-open failures remain failures. Expo FileSystem 57.0.7 is now a direct dependency at the already installed version; no package versions changed.027459fbuild and four groups match their receipt hashes. An earlierbc040c0XCTest log changed after hashing. Current publication copies ordinary files into an immutable directory and hashes the same buffers it writes. Hidden-file exclusions match the uploader, and interrupted runs receive failed receipts.22d76f2, passed both iPad groups: four complete solo/three-AI games, largest iPad text resume, damaged-save/database preservation, cancelled reset, explicit reset and empty relaunch. All 361 declared build/group files match downloaded hashes. Both phone groups still failed, so the required quality gate remained failed.1d4f948, passed the full phone-six group, including solo/three-AI completion and largest-text resume. The local MCP driver also completed phone-five and both tablet solo games; tablet-ten AI reached saved results. Phone-five then failed on an offscreen Cancel preview action, tablet-eight AI failed its first score acknowledgment, and tablet-ten AI failed its History navigation. The matrix remained failed. All 862 declared build/group files match downloaded hashes.930a70drun passed both tablet groups and phone-five solo, including those earlier failures. Geometry checks, single scoring taps, acknowledgments and persisted completion requirements remain unchanged.930a70d, passed phone-six and both tablet groups, both largest-text scenarios, damaged-save/database preservation and explicit reset/relaunch. Phone-five solo also passed. Seven of eight complete-game scenarios passed. Phone-five landscape/three-AI failed at its first die interaction, so the matrix remained failed. All 1,065 declared build/group files match downloaded size/hash inventories.8fbf386is historical; fresh review is required for the current head.8fbf386, passed compilation, Linux/Windows and mutation checks, but all four native groups stopped before their first hold tap. The native hierarchy places the play View's test ID as a leaf beside its children, not above them. The current guard accepts real ancestry or the observed leaf-marker shape in the same immediate container, with full geometric containment. Die ancestry inside its actual scroll view remains mandatory. A captured hierarchy excerpt reproduced the failure before repair; detached markers and unrelated dice remain rejected. All four original hierarchies now produce valid geometry decisions in the local regression check. All 98 declared build/group files match downloaded inventories. This is not a substitute for the new native run.9373563passed both phone groups in its original run and the complete same-head evidence-regeneration run. Both tablet groups failed. In attempt 2, tablet-eight's first hold target was fully visible and geometrically contained, but its single tap changed neither the UI nor the saved document. Tablet-ten missed a setup choice-sheet transition. All 739 declared build/four-group files downloaded from attempt 2 match size/hash inventories. Original-run artifacts expired before retrieval; their absent bytes are not claimed as retained evidence. Its clean Codex review is historical.Current-source native UI evidence
These original RGB images and explicit pixel-identical RGB exports and the original 7-minute45-second recording come from the passing source86011d8 qualification. They show played games, not injected display fixtures. Expanded iPad captures retain the simulator's original stored orientation. They are engineering evidence, not App Store screenshots or a store-preview video. Phone-six images come from the passing attempt2 artifact.
Original phone-five qualification recording:
native-resume.mp4
Explicit RGB engineering exports
These exported images have no alpha channel. Every source pixel was fully opaque; the exports preserve decoded color samples, dimensions and all ancillary metadata byte for byte, including the original stored orientation. No compositing, cropping, resizing or overlay was applied. Original captures remain retained and linked below. These are engineering images, not accepted App Store captures.
Original capture for phone-play-light.png
Original capture for phone-largest-text.png
Original capture for tablet-expanded-light.png
Original capture for tablet-expanded-dark.png
Original capture for tablet-largest-text.png
Risks and deferred work
Public identity/rights and release scope remain owner decisions in #39. Existing development identifiers and proposed version 1.0.0/build 1 are not approved public branding. No Apple app record, signing, upload, TestFlight, legal declarations, contact publication or store submission is performed here.
Real-device airplane-mode, VoiceOver, interruption, backup/restore and signed-distribution acceptance remain unproven. The iOS SQLite directory is eligible for OS-controlled backup; Reset does not erase existing backups. No application-level encryption is configured.
See native storage and simulator qualification for the contracts and evidence limits.